Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo test to recert presubmits #50358

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add cargo test to recert presubmits #50358

merged 1 commit into from
Mar 28, 2024

Conversation

mresvanis
Copy link
Contributor

@mresvanis mresvanis commented Mar 28, 2024 •
edited
Loading

This PR adds cargo test to recert presubmits. Related recert PR rh-ecosystem-edge/recert#120.

@mresvanis
Add cargo test to recert presubmits
bc5f33c 
Signed-off-by: Michail Resvanis <mresvani@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@mresvanis
Copy link
Contributor Author

/test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mresvanis: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-rh-ecosystem-edge-recert-main-cargo-test rh-ecosystem-edge/recert presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@mresvanis
Copy link
Contributor Author

/pj-rehearse pull-ci-rh-ecosystem-edge-recert-main-cargo-test

@mresvanis mresvanis marked this pull request as ready for review March 28, 2024 17:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@openshift-ci openshift-ci bot requested review from omertuc and smg247 March 28, 2024 17:09
@mresvanis
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 28, 2024
@omertuc
Copy link
Contributor

omertuc commented Mar 28, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mresvanis, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@mresvanis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 20ef868 into openshift:master Mar 28, 2024
19 checks passed
qiliRedHat pushed a commit to qiliRedHat/release that referenced this pull request Mar 29, 2024
@mresvanis @qiliRedHat
Add cargo test to recert presubmits (openshift#50358)
ebf1e6c 
Signed-off-by: Michail Resvanis <mresvani@redhat.com>
@mresvanis mresvanis deleted the add-cargo-test-to-recert-presubmits branch March 29, 2024 09:22
BradLugo pushed a commit to BradLugo/openshift-release that referenced this pull request Jun 13, 2024
@mresvanis @BradLugo
Add cargo test to recert presubmits (openshift#50358)
a8d86b4 
Signed-off-by: Michail Resvanis <mresvani@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omertuc omertuc Awaiting requested review from omertuc

@smg247 smg247 Awaiting requested review from smg247

Assignees

@omertuc omertuc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mresvanis @openshift-ci-robot @omertuc